components/lightspeed_ecom_c_series/sources/product-deleted/test-event.mjs (1)

1-1: Empty sample payload — please provide a minimal, realistic shape or add rationale

An empty object makes downstream examples / UI previews unhelpful. If Lightspeed sends no body on delete, add a comment stating that. Otherwise, include the minimal fields (e.g., product id).

Proposed minimal fixture (verify against actual webhook shape before committing):

-export default {}
+export default {
+  product: {
+    id: 123
+  }
+}

components/lightspeed_ecom_c_series/sources/invoice-updated/test-event.mjs (1)

1-52: Prefer HTTPS in sample links

All “link” values use http://. Use https:// to avoid shipping insecure URLs in examples and quiet security scanners. Apply this across all test-event fixtures.

Example (repeat for all “link” fields in this file):

- "link":"http://api.shoplightspeed.com/en/orders/123.json"
+ "link":"https://api.shoplightspeed.com/en/orders/123.json"

components/lightspeed_ecom_c_series/sources/order-updated/test-event.mjs (2)

10-11: Use reserved placeholders for IP/email

Swap the real-looking IP and non-reserved email domain for doc-safe placeholders.

- "remoteIp":"35.245.159.47",
+ "remoteIp":"203.0.113.10",
...
- "email":"[email protected]",
+ "email":"[email protected]",

Also applies to: 22-22

---

7-7: Order vs. shipment status consistency

Order status is "completed_shipped" while shipmentStatus is "not_shipped". If intentional for edge-case coverage, add a brief comment; otherwise, align them.

Also applies to: 93-94

components/lightspeed_ecom_c_series/sources/customer-updated/test-event.mjs (2)

15-15: Use reserved example email domain

Replace with example.com to avoid referencing a real domain.

- "email":"[email protected]",
+ "email":"[email protected]",

---

59-63: HTTPS links in sample data

Standardize “link” fields to https://.

Example:

- "link":"http:\/\/api.shoplightspeed.com\/en\/groups\/customers.json?customer=123"
+ "link":"https:\/\/api.shoplightspeed.com\/en\/groups\/customers.json?customer=123"

Also applies to: 66-70, 101-106, 109-113

components/lightspeed_ecom_c_series/sources/new-product-created/test-event.mjs (1)

19-23: Switch test links to HTTPS

Same HTTPS concern as other fixtures.

Representative change:

- "link":"http:\/\/api.shoplightspeed.com\/en\/brands\/123.json"
+ "link":"https:\/\/api.shoplightspeed.com\/en\/brands\/123.json"

Also applies to: 26-30, 36-40, 43-47, 50-54, 58-62, 66-70, 73-77, 80-84

components/lightspeed_ecom_c_series/sources/new-order-created/test-event.mjs (2)

10-10: Use reserved placeholders for IP/email

- "remoteIp":"35.245.159.47",
+ "remoteIp":"203.0.113.11",
...
- "email":"[email protected]",
+ "email":"[email protected]",

Also applies to: 22-22

---

615-619: HTTPS for links

Update sample links to https:// across this file.

- "link":"http:\/\/api.shoplightspeed.com\/en\/invoices\/123.json"
+ "link":"https:\/\/api.shoplightspeed.com\/en\/invoices\/123.json"

Also applies to: 640-643, 678-681

components/lightspeed_ecom_c_series/sources/new-customer-created/test-event.mjs (2)

15-15: Use reserved example email domain

- "email":"[email protected]",
+ "email":"[email protected]",

---

59-63: HTTPS links in sample data

Same as other fixtures.

- "link":"http:\/\/api.shoplightspeed.com\/en\/groups\/customers.json?customer=123"
+ "link":"https:\/\/api.shoplightspeed.com\/en\/groups\/customers.json?customer=123"

Also applies to: 66-70, 101-106, 109-113

components/lightspeed_ecom_c_series/lightspeed_ecom_c_series.app.mjs (11)

145-149: Off‑by‑one in brands options pagination.

Other option builders use page + 1 (Lightspeed pagination is 1‑based). Here it passes page directly, likely skipping page 1.

-          params: {
-            page,
-          },
+          params: {
+            page: page + 1,
+          },

---

204-211: Base URL may be incorrect for common cluster values (eu1/us1).

Official guidance maps clusters to fixed API hosts (eu1 → api.webshopapp.com, us1 → api.shoplightspeed.com). Building https://api.${cluster}.com only works if cluster is already webshopapp or shoplightspeed. Add mapping or validate input.

References: elastic.io Lightspeed eCom component docs show the mapping. (docs.elastic.io)

Suggested adjustment:

-    _baseUrl() {
-      return `https://api.${this.$auth.cluster}.com/${this.$auth.lang}`;
-    },
+    _baseUrl() {
+      const c = (this.$auth.cluster || "").toLowerCase();
+      const host =
+        c === "eu1" || c === "eu" ? "api.webshopapp.com" :
+        c === "us1" || c === "us" || c === "noam" ? "api.shoplightspeed.com" :
+        c.includes(".") ? c : `api.${c}.com`;
+      return `https://${host}/${this.$auth.lang}`;
+    },

If you intend cluster to be the host fragment (e.g., webshopapp/shoplightspeed), please document that in the auth UI.

---

18-23: Label building: guard against missing names.

Customers without firstname/lastname render labels with extra spaces. Minor, but easy to harden.

-          label: `${firstname} ${middlename && `${middlename} ` || ""}${lastname} ${email && `(${email})` || ""}`,
+          label: `${[firstname, middlename, lastname].filter(Boolean).join(" ")}${email ? ` (${email})` : ""}`,

---

37-42: Same label hardening suggestion for customer email options.

-          label: `${firstname} ${middlename && `${middlename} ` || ""}${lastname} ${value && `(${value})` || ""}`,
+          label: `${[firstname, middlename, lastname].filter(Boolean).join(" ")}${value ? ` (${value})` : ""}`,

---

56-61: Order options: stabilize when email missing.

Minor parity with the customer label fix.

-          label: `Order #${number} ${email && `(${email})`}`,
+          label: `Order #${number}${email ? ` (${email})` : ""}`,

---

75-81: Order ID options: same label nit.

-          label: `Order #${number} ${email && `(${email})`}`,
+          label: `Order #${number}${email ? ` (${email})` : ""}`,

---

94-99: Shipment number label nit.

-          label: `Shipment #${number} ${status && `(${status})`}`,
+          label: `Shipment #${number}${status ? ` (${status})` : ""}`,

---

113-118: Shipment ID label nit.

-          label: `Shipment #${number} ${status && `(${status})`}`,
+          label: `Shipment #${number}${status ? ` (${status})` : ""}`,

---

132-137: Invoice number label nit.

-          label: `Invoice #${number} ${status && `(${status})`}`,
+          label: `Invoice #${number}${status ? ` (${status})` : ""}`,

---

178-201: Date prop descriptions reference “products” only, but these props are reused for orders, invoices, shipments.

Make the copy generic to avoid confusion in other actions.

-      description: "Show products created after date. **Format: `YYYY-MM-DD HH:MM:SS`**",
+      description: "Show records created after date. **Format: `YYYY-MM-DD HH:MM:SS`**",
@@
-      description: "Show products created before date. **Format: `YYYY-MM-DD HH:MM:SS`**",
+      description: "Show records created before date. **Format: `YYYY-MM-DD HH:MM:SS`**",
@@
-      description: "Show products last updated after date. **Format: `YYYY-MM-DD HH:MM:SS`**",
+      description: "Show records last updated after date. **Format: `YYYY-MM-DD HH:MM:SS`**",
@@
-      description: "Show products last updated before date. **Format: `YYYY-MM-DD HH:MM:SS`**",
+      description: "Show records last updated before date. **Format: `YYYY-MM-DD HH:MM:SS`**",

---

10-11: Minor copy nits.

• “customerid” → “customer ID”
• “Retrieve all customers from a specific customer…” → “Retrieve customers by email.”

-      description: "Retrieve all orders from a specific customer based on the customerid",
+      description: "Retrieve all orders from a specific customer based on the customer ID",
@@
-      description: "Retrieve all customers from a specific customer based on the customer email",
+      description: "Retrieve customers by email",

Also applies to: 29-30

components/lightspeed_ecom_c_series/actions/get-order-products/get-order-products.mjs (1)

6-6: Tweak description grammar and link text.

“Get an order products by ID” → “Get order products for an order ID.”

-  description: "Get an order products by ID. [See the documentation](https://developers.lightspeedhq.com/ecom/endpoints/orderproduct/#get-all-order-products)",
+  description: "Get order products for an order ID. [See the documentation](https://developers.lightspeedhq.com/ecom/endpoints/orderproduct/#get-all-order-products)",

components/lightspeed_ecom_c_series/actions/find-order/find-order.mjs (2)

5-7: Description doesn’t match behavior (filters vs “by ID”).

This action searches with multiple filters, not strictly “by ID”. Reword to avoid confusion.

-  description: "Find an order by ID. [See the documentation](https://developers.lightspeedhq.com/ecom/endpoints/order/#get-all-orders)",
+  description: "Find orders by filters. [See the documentation](https://developers.lightspeedhq.com/ecom/endpoints/order/#get-all-orders)",

---

62-76: Optional: add a max results cap to avoid unintentionally paging the entire dataset.

Expose limit (mapped to page_size) and/or maxResults passed to paginate.

-    const response = this.app.paginate({
+    const response = this.app.paginate({
       fn: this.app.listOrder,
       $,
       params: {
         customer: this.customerId,
         number: this.orderNumber,
         since_id: this.sinceId,
         created_at_min: this.createdAtMin,
         created_at_max: this.createdAtMax,
         updated_at_min: this.updatedAtMin,
         updated_at_max: this.updatedAtMax,
       },
       dataField: "orders",
+      // maxResults: 500, // uncomment to cap results
     });

components/lightspeed_ecom_c_series/actions/find-shipment/find-shipment.mjs (3)

5-7: Description doesn’t match behavior

This action lists/filters shipments; it’s not “by ID.” Align name/description with actual filters.

-  name: "Find Shipment",
-  description: "Find a shipment by ID. [See the documentation](https://developers.lightspeedhq.com/ecom/endpoints/shipment/#get-all-shipments)",
+  name: "Find Shipments",
+  description: "Find shipments using filters (customer, order, number, date range). See docs: Get all shipments.",

---

16-26: Property copy edits

• “customerid” → “customer ID”.
• Clarify order/shipment number behavior.

-      description: "Retrieve all shipments from a specific customer based on the customerid",
+      description: "Retrieve shipments for a specific customer ID",
...
-      description: "Retrieve a shipment based on the order number",
+      description: "Retrieve shipments for an order number",

---

73-82: Avoid sending undefined filters

Filter out empty/undefined params to prevent noisy requests.

-      params: {
-        customer: this.customerId,
-        order: this.orderNumber,
-        number: this.shipmentNumber,
-        since_id: this.sinceId,
-        created_at_min: this.createdAtMin,
-        created_at_max: this.createdAtMax,
-        updated_at_min: this.updatedAtMin,
-        updated_at_max: this.updatedAtMax,
-      },
+      params: Object.fromEntries(Object.entries({
+        customer: this.customerId,
+        order: this.orderNumber,
+        number: this.shipmentNumber,
+        since_id: this.sinceId,
+        created_at_min: this.createdAtMin,
+        created_at_max: this.createdAtMax,
+        updated_at_min: this.updatedAtMin,
+        updated_at_max: this.updatedAtMax,
+      }).filter(([, v]) => v != null && v !== "")),

components/lightspeed_ecom_c_series/actions/find-customers/find-customers.mjs (3)

5-7: Description mismatch

You’re finding customers via filters (email, dates), not “by ID.” Align wording.

-  description: "Find a customer by ID. [See the documentation](https://developers.lightspeedhq.com/ecom/endpoints/customer/#get-all-customers)",
+  description: "Find customers using filters (email, date range). See docs: Get all customers.",

---

16-18: Clarify prop phrasing

Current text is awkward.

-      description: "Retrieve all customers from a specific customer based on the customer email",
+      description: "Filter customers by email address",

---

54-67: Param sanitization (optional)

Consider filtering out undefined/empty values for cleaner requests.

-      params: {
-        email: this.customerEmail,
-        since_id: this.sinceId,
-        created_at_min: this.createdAtMin,
-        created_at_max: this.createdAtMax,
-        updated_at_min: this.updatedAtMin,
-        updated_at_max: this.updatedAtMax,
-      },
+      params: Object.fromEntries(Object.entries({
+        email: this.customerEmail,
+        since_id: this.sinceId,
+        created_at_min: this.createdAtMin,
+        created_at_max: this.createdAtMax,
+        updated_at_min: this.updatedAtMin,
+        updated_at_max: this.updatedAtMax,
+      }).filter(([, v]) => v != null && v !== "")),

components/lightspeed_ecom_c_series/actions/find-product/find-product.mjs (2)

5-7: Fix grammar and scope

Use plural and remove “by ID” since this lists/filters.

-  name: "Find Product",
-  description: "Find an product by ID. [See the documentation](https://developers.lightspeedhq.com/ecom/endpoints/product/#get-all-products)",
+  name: "Find Products",
+  description: "Find products using filters (brand, date range). See docs: Get all products.",

---

50-62: Param sanitization (optional)

Keep requests clean by omitting undefined/empty values.

-      params: {
-        brand: this.brandId,
-        since_id: this.sinceId,
-        created_at_min: this.createdAtMin,
-        created_at_max: this.createdAtMax,
-        updated_at_min: this.updatedAtMin,
-        updated_at_max: this.updatedAtMax,
-      },
+      params: Object.fromEntries(Object.entries({
+        brand: this.brandId,
+        since_id: this.sinceId,
+        created_at_min: this.createdAtMin,
+        created_at_max: this.createdAtMax,
+        updated_at_min: this.updatedAtMin,
+        updated_at_max: this.updatedAtMax,
+      }).filter(([, v]) => v != null && v !== "")),

components/lightspeed_ecom_c_series/actions/find-invoice/find-invoice.mjs (3)

5-7: Description mismatch

This action lists/filters invoices; not “by ID.”

-  description: "Find an invoice by ID. [See the documentation](https://developers.lightspeedhq.com/ecom/endpoints/invoice/#get-all-invoices)",
+  description: "Find invoices using filters (customer, order, number, date range). See docs: Get all invoices.",

---

16-26: Copy and semantics fixes

• “customerid” → “customer ID”.
• Order filter prop describes fetching an order; should reference invoices for an order number.

-      description: "Retrieve all invoices from a specific customer based on the customerid",
+      description: "Retrieve invoices for a specific customer ID",
...
-      description: "Retrieve an order based on the order number",
+      description: "Retrieve invoices for an order number",

---

74-83: Omit undefined filters (optional)

Mirror other comments: filter out empty values before calling.

-      params: {
-        customer: this.customerId,
-        number: this.invoiceNumber,
-        order: this.orderNumber,
-        since_id: this.sinceId,
-        created_at_min: this.createdAtMin,
-        created_at_max: this.createdAtMax,
-        updated_at_min: this.updatedAtMin,
-        updated_at_max: this.updatedAtMax,
-      },
+      params: Object.fromEntries(Object.entries({
+        customer: this.customerId,
+        number: this.invoiceNumber,
+        order: this.orderNumber,
+        since_id: this.sinceId,
+        created_at_min: this.createdAtMin,
+        created_at_max: this.createdAtMax,
+        updated_at_min: this.updatedAtMin,
+        updated_at_max: this.updatedAtMax,
+      }).filter(([, v]) => v != null && v !== "")),

components/lightspeed_ecom_c_series/sources/order-updated/order-updated.mjs (2)

6-8: Key prefix inconsistent with app

Other modules use lightspeed_ecom_c_series-.... Align for discoverability and to avoid collisions.

-  key: "indiefunnels-order-updated",
+  key: "lightspeed_ecom_c_series-order-updated",

---

8-9: Grammar fix

“a order” → “an order”.

-  description: "Emit new event when a order is updated.",
+  description: "Emit new event when an order is updated.",

components/lightspeed_ecom_c_series/sources/product-deleted/product-deleted.mjs (2)

6-8: Key prefix inconsistent with app

Use the same lightspeed_ecom_c_series- prefix used elsewhere.

-  key: "indiefunnels-product-deleted",
+  key: "lightspeed_ecom_c_series-product-deleted",

---

20-26: Potential null deref with empty sample

generateMeta assumes body.product.id and deletedAt. The referenced test-event is empty in this PR; sample display may break.

I can supply a minimal test-event.mjs:

export default {
  product: {
    id: 123,
    deletedAt: "2025-09-17T20:25:55+00:00",
  },
};

components/lightspeed_ecom_c_series/sources/order-shipped/test-event.mjs (1)

7-7: Align sample payload with “shipped” semantics

The order status shows completed_shipped, but shipmentStatus and shipments[].status are “not_shipped”. Align for clarity.

-     "shipmentStatus":"not_shipped",
+     "shipmentStatus":"shipped",

-                 "status":"not_shipped",
+                 "status":"shipped",

Also applies to: 339-339, 93-94

components/lightspeed_ecom_c_series/sources/new-customer-created/new-customer-created.mjs (1)

8-8: Grammar nit: “a customer”.

Change “an customer” → “a customer”.

Apply this diff:

-  description: "Emit new event when an customer is created.",
+  description: "Emit new event when a customer is created.",

components/lightspeed_ecom_c_series/sources/common/base.mjs (1)

35-38: Guard deactivation when no webhookId is stored.

Avoid calling deleteHook(undefined) on first deploys or if state was cleared.

Apply this diff:

     async deactivate() {
       const webhookId = this._getWebhookId();
-      await this.app.deleteHook(webhookId);
+      if (!webhookId) return;
+      await this.app.deleteHook(webhookId);
     },

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.

Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.

components/lightspeed_ecom_c_series/sources/customer-updated/customer-updated.mjs (1)

20-26: Event loss: dedupe strategy still collapses multiple updates.

With dedupe: "unique" on line 11, using only body.customer.id (line 22) as the meta ID causes subsequent updates to the same customer to be dropped. The previous review comment provided a comprehensive fix including optional chaining, timestamp-based unique IDs, and safe fallback for invalid dates—this feedback remains unaddressed.

Please apply the previously suggested diff (or a similar approach) to ensure each customer update generates a distinct event.

components/lightspeed_ecom_c_series/sources/new-customer-created/new-customer-created.mjs (1)

20-26: Add defensive null checks to prevent runtime crashes.

The generateMeta method accesses nested properties (body.customer.id, body.customer.createdAt) without checking if they exist. If the webhook payload is malformed or missing expected fields, this will throw at runtime and crash the source.

Apply this diff to add optional chaining and fallbacks:

 generateMeta(body) {
+  const id = body?.customer?.id;
+  const ts = Date.parse(body?.customer?.createdAt) || Date.now();
   return {
-    id: body.customer.id,
-    summary: `Customer with ID ${body.customer.id} created`,
-    ts: Date.parse(body.customer.createdAt),
+    id,
+    summary: `Customer with ID ${id} created`,
+    ts,
   };
 },

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro